Repository navigation
feat(sandbox): let a subagent's space carry environment directories - #762
Merged
Merged
Conversation
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 12, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #761.
PreparedSpace::with_env_dir(name, path)records a variable naming a directory inside the space;confinerefuses one outside it, as it does working copies.launch_resolvedhands the prepared variables to the subagent's sandbox as a space layer thatderivedresets, so a nested subagent carries only its own. The host backend applies the layer after the sandbox environment andEnvSourceand before a spec's variables; the container backend exports it between the source's and the spec's, each path as the container sees it through the workspace mount.Tests cover the layer order on the host, the container exports through the mount, a path outside the space failing the launch, and an end-to-end subagent (host and recording container) seeing its own directories while a nested one sees only its own.